Skip to content

[v16.x backport] WPT runner update and crypto followups - #44872

Closed
panva wants to merge 0 commit into
nodejs:v16.x-stagingfrom
panva:backport-lots-to-v16.x
Closed

[v16.x backport] WPT runner update and crypto followups#44872
panva wants to merge 0 commit into
nodejs:v16.x-stagingfrom
panva:backport-lots-to-v16.x

Conversation

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Oct 3, 2022
@panva
panva force-pushed the backport-lots-to-v16.x branch from da76d2f to 55bf5cd Compare October 3, 2022 09:13
@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Oct 3, 2022
@panva
panva marked this pull request as ready for review October 3, 2022 09:14
@panva

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

lint failures unrelated to the changes in this PR

@panva

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

cc @juanarbol @daeyeon

@daeyeon

daeyeon commented Oct 3, 2022

Copy link
Copy Markdown
Member

@panva Thanks for this backporting.

@panva

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

Also cc @nodejs/backporters, didn't mean to step on anyone's toes here. Since I've not done backporting before, I followed doc/contributing/backporting-to-release-lines.md for every single commit except I've added them all into a single branch and PR.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2022
@nodejs-github-bot

This comment was marked as outdated.

@panva

panva commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

CI failures are most likely present on v16.x-staging as well (both lint and test.parallel/test-net-socket-*)

@nodejs-github-bot

This comment was marked as outdated.

@panva

panva commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

image

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva

panva commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

The CI results are the same as for the v16.x proposal / staged changes. When those are resolved this is good to re-run and land.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva
panva force-pushed the backport-lots-to-v16.x branch from b758f43 to 1805fe0 Compare October 7, 2022 17:56
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
PR-URL: nodejs#43455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Backport-PR-URL: nodejs#44872
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
PR-URL: nodejs#44170
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44872
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
PR-URL: nodejs#44171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44872
panva added a commit to panva/node that referenced this pull request Oct 8, 2022
PR-URL: nodejs#44172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44872
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@juanarbol

Copy link
Copy Markdown
Member

Landed in bc20e470d7...54b96355cf 🎉 💚

Muchas gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants